Error en imports que se hacen desde diferentes packages (el orden causa error) #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdodino
changed the title
fdodino
force-pushed
the
fix-missing-reference-imports
branch
from
a95e3a9 to
006cbd3
Compare
|
Ahi estuvimos con @ivojawer y lo resolvimos asegurando de asignar todos los scopes de packages antes de ir por los modules. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #306 +/- ##
=======================================
Coverage 89.75% 89.75%
=======================================
Files 28 28
Lines 3171 3172 +1
Branches 574 574
=======================================
+ Hits 2846 2847 +1
Misses 169 169
Partials 156 156 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
PalumboN
approved these changes
Nov 19, 2024
Comment on lines
+118
to
+120
| }) | ||
|
|
||
| root.forEach((node, _parent) => { |
| expect(result).to.equal('"hola"') | ||
| }) | ||
|
|
||
| it('should be able to execute sentences related to a hierarchy defined in different packages - 2', () => { |
There was a problem hiding this comment.
Por qué 2? Y qué onda con mandarlos para language como sanity?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sobre el problema reportado en #308, me tomó mucho laburo tratar de reproducirlo, pero acá dejo dos tests:
no funciona
new B().bla()(dice que no lo entiende). Si en cambio hacés:funciona perfectamente.
@ivojawer @PalumboN , me gustaría verlo en nuestras sesiones de los martes.